inspektr ClientInfoHolder InheritableThreadLocal problem

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

inspektr ClientInfoHolder InheritableThreadLocal problem

leeyc0
I am attempting to find the root cause of tomcat warning Thread Local memory leak problem during shutdown, and I found that if I change inspektr ClientInfoHolder.clientInfoHolder from InheritableThreadLocal to ThreadLocal, the warning goes away. Is there any reason that ClientInfoHolder.clientInfoHolder should be inhertible? I tried to study CAS code and seems don't observe any thread is used (except thread pools to connecting external storage/authentication) during the lifetime of a HTTP connection.

Please correct me if I am incorrect.

--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/445478e4-f687-47b9-ab4d-aeb3aab568d0%40apereo.org.
Reply | Threaded
Open this post in threaded view
|

Re: inspektr ClientInfoHolder InheritableThreadLocal problem

leeyc0
Turns out that there is really a thread at core/cas-server-core-audit-api/src/main/java/org/apereo/cas/audit/spi/AbstractAuditTrailManager.java

And this is the culprit that blocks tomcat to shut down...

leeyc0於 2020年4月21日星期二 UTC+8上午11時12分50秒寫道:
I am attempting to find the root cause of tomcat warning Thread Local memory leak problem during shutdown, and I found that if I change inspektr ClientInfoHolder.clientInfoHolder from InheritableThreadLocal to ThreadLocal, the warning goes away. Is there any reason that ClientInfoHolder.clientInfoHolder should be inhertible? I tried to study CAS code and seems don't observe any thread is used (except thread pools to connecting external storage/authentication) during the lifetime of a HTTP connection.

Please correct me if I am incorrect.

--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/063e1053-e277-4369-8f8f-8a8792872156%40apereo.org.