cas.authn.attribute-repository vs cas.authn.attributeRepository

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

cas.authn.attribute-repository vs cas.authn.attributeRepository

Robert
Hi there,

yesterday I've stumbled across CasPersonDirectoryConfiguration.java in cas-server-support-person-directory, while debugging, why my LDAP configuration is not  used to retrieve attributes (jdbc, json and stub were).
I've found out, that CasPersonDirectoryLdapConfiguration is conditionally created when property cas.authn.attribute-repository.ldap[0].ldapUrl exists
My cas.properties was using cas.authn.attributeRepository.ldap[0].ldapUrl, as in the documentation mentions.

Now I found, that there are alot more of these different usages in source code and documentation. Sometimes its cas.authn.attribute-repository and sometimes its cas.authn.attributeRepository. Should I create a PR to unify them or is that on purpose?

Cheers, Robert.

--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/d357fe9b-401b-4173-af92-c36aa2fe6d2e%40apereo.org.
Reply | Threaded
Open this post in threaded view
|

Re: cas.authn.attribute-repository vs cas.authn.attributeRepository

Dmitriy Kopylenko-3


On March 5, 2020 at 07:13:33, Robert ([hidden email]) wrote:

Hi there,

yesterday I've stumbled across CasPersonDirectoryConfiguration.java in cas-server-support-person-directory, while debugging, why my LDAP configuration is not  used to retrieve attributes (jdbc, json and stub were).
I've found out, that CasPersonDirectoryLdapConfiguration is conditionally created when property cas.authn.attribute-repository.ldap[0].ldapUrl exists
My cas.properties was using cas.authn.attributeRepository.ldap[0].ldapUrl, as in the documentation mentions.

Now I found, that there are alot more of these different usages in source code and documentation. Sometimes its cas.authn.attribute-repository and sometimes its cas.authn.attributeRepository. Should I create a PR to unify them or is that on purpose?

Cheers, Robert.
--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/d357fe9b-401b-4173-af92-c36aa2fe6d2e%40apereo.org.

--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/etPan.5e60fdf0.7a741f28.23f%40unicon.net.
Reply | Threaded
Open this post in threaded view
|

Re: cas.authn.attribute-repository vs cas.authn.attributeRepository

Robert

Thanks for your answer, but unfortunately they are not equal both.

I've remote debugged my IdP running 6.2.0-RC3 and Bean CasPersonDirectoryLdapConfiguration inside CasPersonDirectoryConfiguration.java (line 371) was not created, unless I changed cas.authn.attributeRepository.ldap[0].ldapUrl to cas.authn.attribute-repository.ldap[0].ldapUrl.


Cheers, Robert



Am Donnerstag, 5. März 2020 14:26:12 UTC+1 schrieb Dmitriy Kopylenko:
CAS uses Spring Boot’s “relaxed binding”, <a href="https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-external-config-relaxed-binding" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fdocs.spring.io%2Fspring-boot%2Fdocs%2Fcurrent%2Freference%2Fhtml%2Fspring-boot-features.html%23boot-features-external-config-relaxed-binding\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNH1Lz4PzfbGF6PZZPb8BaIzArT0pw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fdocs.spring.io%2Fspring-boot%2Fdocs%2Fcurrent%2Freference%2Fhtml%2Fspring-boot-features.html%23boot-features-external-config-relaxed-binding\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNH1Lz4PzfbGF6PZZPb8BaIzArT0pw&#39;;return true;">https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-external-config-relaxed-binding so both styles are OK.

D.


On March 5, 2020 at 07:13:33, Robert (<a href="javascript:" target="_blank" gdf-obfuscated-mailto="MEi2W1gRCwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">robert.k...@...) wrote:

Hi there,

yesterday I've stumbled across CasPersonDirectoryConfiguration.java in cas-server-support-person-directory, while debugging, why my LDAP configuration is not  used to retrieve attributes (jdbc, json and stub were).
I've found out, that CasPersonDirectoryLdapConfiguration is conditionally created when property cas.authn.attribute-repository.ldap[0].ldapUrl exists
My cas.properties was using cas.authn.attributeRepository.ldap[0].ldapUrl, as in the documentation mentions.

Now I found, that there are alot more of these different usages in source code and documentation. Sometimes its cas.authn.attribute-repository and sometimes its cas.authn.attributeRepository. Should I create a PR to unify them or is that on purpose?

Cheers, Robert.
--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="MEi2W1gRCwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">cas...@....
To view this discussion on the web visit <a href="https://groups.google.com/a/apereo.org/d/msgid/cas-dev/d357fe9b-401b-4173-af92-c36aa2fe6d2e%40apereo.org?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/a/apereo.org/d/msgid/cas-dev/d357fe9b-401b-4173-af92-c36aa2fe6d2e%40apereo.org?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/a/apereo.org/d/msgid/cas-dev/d357fe9b-401b-4173-af92-c36aa2fe6d2e%40apereo.org?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;"> https://groups.google.com/a/apereo.org/d/msgid/cas-dev/d357fe9b-401b-4173-af92-c36aa2fe6d2e%40apereo.org.

--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/592c9396-96e9-4de9-ae55-e75611e4ffa2%40apereo.org.